Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record compose #448

Merged
merged 20 commits into from
Nov 9, 2024
Merged

feat: record compose #448

merged 20 commits into from
Nov 9, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Nov 4, 2024

Pull Request

Description

This PR add record audio compose feature and simple record convert server

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 18.39685% with 621 lines in your changes missing coverage. Please review.

Project coverage is 40.91%. Comparing base (4746d6b) to head (5de2a60).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
packages/media_record/bin/convert_record_worker.rs 0.00% 150 Missing ⚠️
packages/media_record/src/convert/composer.rs 0.00% 130 Missing ⚠️
packages/media_record/src/convert/transmuxer.rs 0.00% 94 Missing ⚠️
packages/media_record/bin/convert_record_cli.rs 0.00% 41 Missing ⚠️
...s/media_record/src/convert/composer/audio_mixer.rs 0.00% 36 Missing ⚠️
...ges/media_record/src/convert/transmuxer/summary.rs 0.00% 29 Missing ⚠️
...ages/media_record/src/raw_record/session_reader.rs 0.00% 29 Missing ⚠️
...edia_record/src/convert/transmuxer/track_writer.rs 0.00% 22 Missing ⚠️
packages/media_record/src/convert.rs 0.00% 18 Missing ⚠️
...ckages/media_record/src/raw_record/chunk_reader.rs 0.00% 15 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   41.37%   40.91%   -0.47%     
==========================================
  Files         165      175      +10     
  Lines       18154    19071     +917     
==========================================
+ Hits         7512     7803     +291     
- Misses      10642    11268     +626     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review November 9, 2024 05:57
@giangndm
Copy link
Contributor Author

giangndm commented Nov 9, 2024

Missing video compose is tracking with #450

@giangndm giangndm merged commit c563f2d into 8xFF:master Nov 9, 2024
9 of 11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
@giangndm giangndm deleted the feat-record-compose branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant