Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration failed with mysql database #456

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

giangndm
Copy link
Contributor

Description

This PR fix a migration failed to run with mysql backend

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

@giangndm giangndm marked this pull request as ready for review November 18, 2024 09:20
@giangndm giangndm merged commit 7b55a39 into 8xFF:master Nov 18, 2024
8 checks passed
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.24%. Comparing base (707d96e) to head (91f7855).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tion/m20240824_0001_add_room_destroy_and_record.rs 70.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   36.22%   36.24%   +0.02%     
==========================================
  Files         177      177              
  Lines       18031    18053      +22     
==========================================
+ Hits         6531     6544      +13     
- Misses      11500    11509       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
@giangndm giangndm deleted the fix-migration-mysql branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant