Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pcma decode crash #461

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

giangndm
Copy link
Contributor

Pull Request

Description

Sometime we received strange rtp packet with 200 bytes instead of 160 bytes => reject if != 160 bytes

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

@giangndm giangndm marked this pull request as ready for review November 26, 2024 02:45
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 36.29%. Comparing base (707d96e) to head (698b13c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
packages/media_codecs/src/pcma.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   36.22%   36.29%   +0.07%     
==========================================
  Files         177      177              
  Lines       18031    18076      +45     
==========================================
+ Hits         6531     6560      +29     
- Misses      11500    11516      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm merged commit a782dfb into 8xFF:master Nov 26, 2024
6 of 11 checks passed
@giangndm giangndm deleted the fix-pcma-decoder-crash branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant