Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tunnel stuck #63

Merged
merged 8 commits into from
Sep 29, 2024
Merged

fix: tunnel stuck #63

merged 8 commits into from
Sep 29, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Sep 28, 2024

sometime bi-direct io-copy is unsuccessful. The main reason is:

  • missing wait two direct should completed
  • async-io lib don't process AsyncWriter.poll_close correct

This PR refactor streams implement and implement a custom version base on tokio::io::bidirection_copy

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 728 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e3c7c12). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/protocol/src/stream.rs 0.00% 159 Missing ⚠️
crates/relayer/src/proxy_listener/cluster.rs 0.00% 107 Missing ⚠️
crates/relayer/src/proxy_listener.rs 0.00% 64 Missing ⚠️
crates/agent/src/connection/quic/helper.rs 0.00% 58 Missing ⚠️
crates/protocol/src/cluster.rs 0.00% 44 Missing ⚠️
crates/relayer/src/proxy_listener/tcp.rs 0.00% 42 Missing ⚠️
crates/agent/src/connection/quic/sub_conn.rs 0.00% 34 Missing ⚠️
crates/relayer/src/agent_listener/tcp.rs 0.00% 32 Missing ⚠️
crates/agent/src/local_tunnel/tcp.rs 0.00% 31 Missing ⚠️
crates/relayer/src/agent_listener/quic.rs 0.00% 30 Missing ⚠️
... and 10 more
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #63   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      33           
  Lines           ?    2078           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?    2078           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm merged commit da8820e into 8xFF:main Sep 29, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Sep 29, 2024
@giangndm giangndm mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant