feat: move object directive logic to object function #3308
+49
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6d1789756f7990666f4a0e01761a94816f0fc996
WingT
commented
Sep 28, 2024
| } | ||
| for _, dir := range obj.Directives { | ||
| if dir.IsLocation(ast.LocationInputObject) { | ||
| dirs = append(dirs, dir) |
There was a problem hiding this comment.
why duplicate directives on LocationInputObject?
|
I appreciate your working on this, but I actually really prefer to move logic out of the template files and back into library functions in standard Go files. Template logic is harder to maintain, as linters and other unit testing is much harder to deal with inside of templates. I think your intent of making things simpler and more convenient is a good one though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I6d1789756f7990666f4a0e01761a94816f0fc996
Describe your PR and link to any relevant issues.
#3306
I have: