Fix mpi logic in CABLE SPD #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CABLE spack build leaves the `CABLE_MPI` CMake variable unset when `~mpi` is satisfied and relies on the default value for `CABLE_MPI`. This change removes the if condition around `define_from_variant` so that `CABLE_MPI` is specified to CMake regardless of how the mpi variant is set. Fixes #76
harshula
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CABLE spack build leaves the
CABLE_MPICMake variable unset when~mpiis satisfied and relies on the default value forCABLE_MPI. This change removes the if condition arounddefine_from_variantso thatCABLE_MPIis specified to CMake regardless of how the mpi variant is set.Fixes #76