Blacklist irregular entities from desync fix #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore entities that do not update prevPos. Assume these are entities that don't call Entity#onUpdate(). Related: ACGaming#262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262 by ignoring entities that do not update prevPos. Assume these are entities that don't call Entity#onUpdate(). The main issue was that
utGetDistanceSq()was reliant on those values being updated, which explains the weird behavior once the entities went far enough.If you would like some reasoning for this assumption, specifically for Immersive Vehicles you can see here that the vehicles do not call
super.onUpdate()orsuper.onEntityUpdate(), the latter of which normally updates prevPos inEntity.