Implement better player ticking in AoA #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchung01
force-pushed
the
aoa-better-player-tick
branch
from
9fefa36 to
c954785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweak improves Advent of Ascension player ticking by only sending inventory changes when necessary. Replaces the old AoA tweak as I don't think anyone would run into the edge case of triggering the inventory change while in those GUIs. The tweak is default enabled now that it specifically mixes into the mod. I talked with Tslat about the potential performance issue and have gotten their permission, see below. A similar fix will be added on their side for the actively developed version of the mod.
In my singleplayer world with an endgame base in a large modpack, before:
After:
Performance gains should be even larger in multiplayer scenarios, especially if players have rapidly changing items in their inventory (items with changing NBT/energy, i.e. a jetpack).