Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaken Golem Structure Requirements #465

Merged
merged 2 commits into from
May 12, 2024
Merged

Conversation

WaitingIdly
Copy link
Contributor

@WaitingIdly WaitingIdly commented May 12, 2024

changes in this PR:

  • made is so the iron golem pattern applies '~', unused -> true instead of BlockWorldState.hasState(BlockMaterialMatcher.forMaterial(Material.AIR)), meaning any blocks will match it, not just AIR.
  • made is so forming the iron golem will not replace the side bottom blocks [edit: whoops] or top side blocks.
  • tied to a single config option. (default: false)

basically the same change as #464, but for Iron Golems.

Copy link

what-the-diff bot commented May 12, 2024

PR Summary

  • Update to README.md
    The readme file has been updated to emphasize that the rigid requirements for building Iron Golems have been relaxed.

  • Modification in UTConfigTweaks.java
    A new setting (utGolemPlacement) has been added to toggle the ability of creating Iron Golems. This aims to make Iron Golems' construction possible even when non-air blocks exist in the bottom corners of the base structure.

  • Changes in UTLoadingPlugin.java
    Conditional logic (UTConfigTweaks.ENTITIES.utGolemPlacement) has been included which alters the application of certain modifications based on the configuration setting. This change determines when the newly introduced Iron Golem building rules should be applied.

  • Introduction of UTGolemFormationMixin.java
    A new file has been added that modifies the way Iron Golems are formed and spawned. It allows for Golems to be created with non-air blocks in the lower corners of their structure.

  • Addition of golemstructure.json
    This new JSON mixin file encapsulates modifications associated with the UTGolemFormationMixin class, allowing us to customize how Iron Golems are formed.

@ACGaming ACGaming merged commit 1502caf into ACGaming:main May 12, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the golem-air branch May 12, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants