Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advancement GUI #498

Merged
merged 18 commits into from
Jun 23, 2024
Merged

Advancement GUI #498

merged 18 commits into from
Jun 23, 2024

Conversation

WaitingIdly
Copy link
Contributor

changes in this PR:

  • adds the ability to adjust the Advancement GUI, which controls all lower options (default: false).
  • adds the ability to adjust the size of the Advancement GUI (default: true).
    • control the vertical and horizontal margins independently (default: 50, 50).
    • the minimum height/width cannot go lower than the vanilla default.
  • moves the arrow buttons from above the Advancement GUI to in line with the top advancement row (default: true).
  • removes the screen header indicating what page number you are on out of the maximum (default: false).
  • removes arrow buttons that have no effect when clicked due to already being at the minimum/maximum page number (default: true).
  • disables the background fade effect when hovering advancements (default: true).
  • adds the focused tab to the header, which otherwise is only "Advancements" (default: true).
  • use the access transformer to make the AdvancementTabType enum public (required to properly use some mixins on it).

Copy link

what-the-diff bot commented Jun 23, 2024

PR Summary

  • Enhanced README Document
    The README document has new added information regarding a feature called "Advancement GUI." This feature comes with several sub-features that improve user interface and experience. It can modify the size of the Advancement GUI to be in proportion to the screen size, refine the placement of page buttons, disable page switching at the extremes, as well as stop the background from fading when an advancement is highlighted. In addition, a new "Advancement Page Title" text has been introduced to the GUI header.

  • New Java Files Added
    Three new Java files were added to the project:

    • UTAdvancementInfo.java, which lives in mod/acgaming/universaltweaks/tweaks/misc/advancements/guisize directory.
    • UTAdvancementTabTypeMixin.java, present in mod/acgaming/universaltweaks/tweaks/misc/advancements/guisize/mixin directory.
    • UTGuiAdvancementTabMixin.java, located in the same directory as UTAdvancementTabTypeMixin.
      These files add additional functionality to the 'advancement' feature set.
  • Language File Updated
    In the English language file (en_us.lang), a new line was added that represents identifier for 'Advancements'.

  • New JSON File Added
    A new JSON file named mixins.tweaks.misc.advancements.guisize.json was incorporated which is likely related to appearance and behavior of advancement GUI.

  • Configuration File Adjusted
    In the configuration file universaltweaks_at.cfg, new classes and fields were added related to the 'Advancement Tab Type' component of the software. They may indicate the ability for the Advancement Tab to be shown in various positions, such as above, below, right, and left.

@ACGaming ACGaming merged commit 5f6fc3a into ACGaming:main Jun 23, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the advancement-gui branch June 23, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants