Improve confetti creepers tweak, fix some client-side things being loaded on server #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make TextureMapCheck client-side mixin - Use built-in SideOnly method to spawn particles for creeper confetti
- Now the chance to be confetti creeper is checked once on server-side spawn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple client-side tweaks were trying to be loaded on the physical server, which errored in logs.
Namely, (1) moved TextureMapCheck tweak to client, and (2) adjusted Confetti Creeper tweak to use the built-in client-side
World#makeFireworks.While I was at it, I noticed confetti creeper tweak was using independent chances on server vs client. Changed it to check the chance on server-side creeper spawn, so it should be synced better now. This means the chance depends on the server's config only now.