Disable elytra render tweak if OpenMods is present #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- OpenMods may load vanilla classes too early in its transformer - Specific OpenMods patch this tweak conflicts with is 'activate_player_render_hook'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenMods may load vanilla classes too early in its transformer. This can cause some UT mixins to fail and cause issues. It seems certain mod configurations don't have this problem though for whatever reason (probably transform load order related). Specific OpenMods patch this tweak conflicts with is
activate_player_render_hookif true.This doesn't check the config option from OpenMods though as that may be a bit more complicated.