Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Auto Jump Replacement" more compatible #530

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Conversation

jchung01
Copy link
Contributor

Fixes #523.

Copy link

what-the-diff bot commented Jul 28, 2024

PR Summary

  • Integration of unique import from SpongePowered Mixin
    The team has integrated a new import from the org.spongepowered.asm.mixin.Unique library. This is critical for upcoming enhancements.
  • Introduction of 'step assistance' for player
    A new variable- Field 'stepAssisted' has been created. This will add a 'step assistance' feature for the player.
  • Modification in AutoJump Method
    The method previously used for 'AutoJump' has been modified. Now, before setting the player's step height, we check if the player is in the 'step-assisted' mode. It provides a more responsive and user-intuitive jumping experience.
  • Condition-based Step Assists
    The system is now equipped to perform auto-checks. If auto jump is enabled and the player's step height is less than 1.0f, the system will set 'stepAssisted' mode on and update the player's step height accordingly. It brings a smoother and more accurate stepping experience.
  • Condition for turning off Step Assists
    A new condition has been added to turn off the 'step-assisted' mode whenever needed. If 'stepAssisted' is true and the player's step height is more than 0.6f, the system will deactivate the 'step-assisted' mode. This ensures an adaptable player experience based on game events.
  • Various edits on initial lines of the code
    Non-functional but important adjustments have been made to the initial 28 lines of code including imports and annotations. These are to improve code readability and maintainability.

@jchung01 jchung01 marked this pull request as draft July 28, 2024 06:59
@jchung01 jchung01 marked this pull request as ready for review July 28, 2024 18:57
@jchung01
Copy link
Contributor Author

My initial change technically worked, but it was changing step height between 0.6 and 1.25 every other tick. This way should be better and I think functionally behaves the same.

@ACGaming ACGaming merged commit 5886bff into ACGaming:main Jul 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Compatibility] Auto Jump step assist replacement makes Void Thaumaturge Boots own step assist not work
2 participants