Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify last stand mixin #535

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Simplify last stand mixin #535

merged 3 commits into from
Aug 14, 2024

Conversation

jchung01
Copy link
Contributor

Moves last stand fix into the LastStandEnchantmentsHandler mixin, removing the need of capturing the event handler. No more NPEs if it wasn't captured due to disabling the enchant in the config.
Fixes #534.

Copy link

what-the-diff bot commented Aug 13, 2024

PR Summary

  • Removal of UTOpenBlocksEvents class
    The UTOpenBlocksEvents class from the mod.acgaming.universaltweaks.mods.openblocks package has been removed. This could lead to performance improvements if it was redundant.

  • Deletion of UTConfigMixin class
    The UTConfigMixin class from the mod.acgaming.universaltweaks.mods.openblocks.mixin package has also been deleted. This might translate to better efficiency in the application if the class was no longer in use.

  • Update to UTLastStandEnchantmentsHandlerMixin Class
    We've introduced two new methods, onHurt and ut$fixLastStand, in the UTLastStandEnchantmentsHandlerMixin class from the mod.acgaming.universaltweaks.mods.openblocks.mixin package. This could be helpful in managing events related to the 'last stand' enchantments more efficiently.

  • Changes to the mixins.mods.openblocks.json File
    Alterations have been made to the mixins.mods.openblocks.json file. These modificiations will likely improve how we incorporate openblock modifications into our project.

@ACGaming ACGaming merged commit f5f8c88 into ACGaming:main Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weird invincibility bug after updating to latest version
2 participants