Get ExtendedBlockState before rendering in block overlay fix #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely an expert on rendering, but the block of code used to render the overlay in the block overlay fix seems to mirror
BlockRendererDispatcher#renderBlock()
. However, unlike that method, the fix was missing a call to get the block'sIExtendedBlockState
if it had one. This was the root cause of the crashes that have been reported with this fix. I tested AE2-UEL v0.56.4 (which has the ME Drive crash) and Roost (which has the roost block crash), and neither of them crash now. This means the ME Drive doesn't need to be in the blacklist now.Fixes #533. Fixes #547.