Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ExtendedBlockState before rendering in block overlay fix #548

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

jchung01
Copy link
Contributor

Not entirely an expert on rendering, but the block of code used to render the overlay in the block overlay fix seems to mirror BlockRendererDispatcher#renderBlock(). However, unlike that method, the fix was missing a call to get the block's IExtendedBlockState if it had one. This was the root cause of the crashes that have been reported with this fix. I tested AE2-UEL v0.56.4 (which has the ME Drive crash) and Roost (which has the roost block crash), and neither of them crash now. This means the ME Drive doesn't need to be in the blacklist now.
Fixes #533. Fixes #547.

Copy link

what-the-diff bot commented Aug 28, 2024

PR Summary

  • State Update in Blocks
    The update involves calling a method that extends a block's state. It's like asking the block to show more information than it does by default, which could beneficially impact how we display or interact with blocks in the system.

  • Configuration Bugfixes
    We've cleared a list initially containing certain blocks not allowed for overlay. This means now all the blocks should be eligible for overlays, improving the flexibility and user experience of our system.

@ACGaming ACGaming merged commit c5ddc55 into ACGaming:main Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants