Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RandomPatches timeout tweaks #556

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

jchung01
Copy link
Contributor

@jchung01 jchung01 commented Sep 25, 2024

Adds read/login timeout patches from RandomPatches (RP). Helps slower PCs connect to servers in a large modpack. I did not include the keepAlivePacketInterval patch because it didn't seem necessary judging from the pinned issues in RP's repo.

Shouldn't cause issues if RandomPatches is installed, RP's modifications either take priority or stack with these.

- Excludes KeepAlive interval tweak as it doesn't seem necessary
Copy link

what-the-diff bot commented Sep 25, 2024

PR Summary

  • New Feature: Connection Timeouts
    This PR provides an added functionality for clients that have slower connections. A new feature known as Connection Timeouts has been introduced, which permits tunable read/login timeouts. This allows slow clients to establish connections to large modpacks.

  • Documentation
    The new feature is well-documented in the README.md file, providing detailed instructions on how to configure and utilize Connection Timeouts.

  • Configuration Changes
    The UTConfigTweaks.java file has been revised to include a new category, TimeoutsCategory, specifically for configuring the timeouts.

  • Timeout Management
    A new class, UTTimeoutManager.java, has been introduced to manage the read and login timeouts.

  • Network Behavior Manipulation
    This PR introduces specific mixins to adjust the networking behavior of Minecraft. There are modifications related to client read timeout (handled by UTClientReadTimeoutMixin), login timeout for servers (UTLoginTimeoutMixin), and changes in the keep-alive behavior based on the read timeout (UTServerReadTimeoutMixin).

  • Configuration Files
    New JSON configuration files for the new mixins have been added, enhancing the flexibility and customizability of the system.

  • Interface Localization
    Lastly, the language file has been updated to reflect the new feature, ensuring continuity in user interface and experience.

@ACGaming ACGaming merged commit beb9efe into ACGaming:main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants