Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vengeance Spirit Regex Cache #599

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

WaitingIdly
Copy link
Contributor

changes in this PR:

  • adds a cache to to EvilCraft's Vengeance Spirit config, which works based on regex.

ran into a situation where a very large number of Pattern objects were being created every tick.

Copy link

what-the-diff bot commented Dec 12, 2024

PR Summary

  • Added Compatibility With "EvilCraft" Mod
    This update adds support for the popular "EvilCraft" mod, allowing it to work seamlessly with our software.

  • Improved Performance for EvilCraft Mod Features
    By implementing a cache for the Vengeance Spirit checks, we've reduced the performance costs when utilizing the EvilCraft mod. This should lead to a smoother in-game experience.

  • Updated Documentation with EvilCraft Features
    The README file has been updated to include the new features related to EvilCraft. This will help users to understand the functionalities enabled by this integration.

  • Incorporated EvilCraft as a Dependency
    Essential configurations have been added in dependencies.gradle and gradle.properties to include EvilCraft as a dependency, which allows for its features to be used within our software.

  • Added Configuration Options for EvilCraft
    New configuration class EvilCraftCategory is created to manage all EvilCraft-related settings, paving the way for further customizations from the user's end.

  • Enhanced Functionality for Vengeance Spirit
    New mixing functionality was added for the Vengeance Spirit class along with caching logic. This addition expands the gameplay possibilities for players using EvilCraft.

  • Localized Text for EvilCraft
    Updated our software's language file, en_us.lang, to include EvilCraft-specific terminology, enhancing the user's understanding and immersion.

  • Improved Coding Configuration for EvilCraft
    By introducing a dedicated mixin configuration for the mod, mixins.mods.evilcraft.vengeancespirit.json, we made our software's interaction with EvilCraft much more streamlined and organized, aiding in future development efforts.

@ACGaming ACGaming merged commit 3f429cc into ACGaming:main Dec 13, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the evilcraft-regex-cache branch December 13, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants