Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous EnderIO fixes #601

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Conversation

WaitingIdly
Copy link
Contributor

@WaitingIdly WaitingIdly commented Dec 16, 2024

changes in this PR:

  • fix Chorus Farming StackOverflow via ensuring duplicate positions are not checked. (default: true)
  • fix broken entries appearing in the Soul Binder JEI category via skipping the output if its focused on a soul vial and not overriding the contents of a slot if the list is empty. (default: true)
  • fix the damage panel for advanced filters not saving the state selected. (default: true)
  • fix a duplication issue involving MmmMmmMmmMmm via making the Dummy copy the equipment and not drop any instead of consume the equipment from the main hand. (default: true)
    • i investigated multiple ways to fix this problem without requiring this step and couldnt identify such a way. it is caused because EntityDummy#equipArmor reduces the stack size during EntityLiving#processInitialInteract, and if that stack is empty, it uses a previously copied instance to fire PlayerDestroyItemEvent, which EnderIO subscribes to and when it outputs all the items.
    • this may need more testing to ensure there isnt some edge case in which the armor can be extracted
  • sorted the mixin maps alphabetically, as a few were out of order.

Copy link

what-the-diff bot commented Dec 16, 2024

PR Summary

  • Improved README Document
    The README file has been updated to provide detailed fixes for issues related to the Ender IO mod. This includes resolution of an issue causing the system to overflow with excess data during Chorus Farming, fixing display issues for the Soul Binder in JEI, reducing complexity in the Obelisk Renderer to prevent memory leaks, and ensuring that cycle buttons report user interactions accurately.

  • New Configuration Options for "MmmMmmMmmMmm" Mod
    A new configuration category has been introduced to allow the mod to copy armor stacks instead of dropping them.

  • More Configuration Options for Ender IO Mod
    Several configuration options have been incorporated into UTConfigMods.java, all related to the Ender IO mod. These are designed to provide fixes to previously mentioned issues, including proper interaction reports for filter cycle buttons.

  • Enhanced UTLoading Plugin
    This plugin has been upgraded to include additional configurations, useful for implementing the Ender IO mod fixes.

  • New Mixins for Ender IO Mod
    Several new mixins for the Ender IO mod have been crafted including prevention of duplicated positions in Chorus Farming, better management of cycle button interactions in picker overlays, and improved handling of the Soul Binder's recipes output displays.

  • New Mixins for Test Dummy Integration
    For the new Test Dummy Integration, mixins have been implemented to allow copying of armor stacks, and to prevent dropping of the original stack.

  • Updated Gradle Files
    gradle.properties and dependencies.gradle files have been updated to include debug configurations for the Test Dummy mod.

  • Renamed File and Added New Mixins Configuration Files
    The file mixins.mods.enderio.json has been renamed to mixins.mods.enderio.itemrender.json, and its package path has been updated accordingly. New mixin configuration files have also been added to enhance the integration of the soul binder JEI and the copy armor functionality in their respective mods.

@ACGaming ACGaming merged commit e58fe99 into ACGaming:main Dec 17, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the enderio-fixes branch December 20, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants