Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GV-64] write-tests-for-api-v2-verifyaccess-index-js #26

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

paulinaai
Copy link
Contributor

Jira Ticket

Jira Ticket

Description

The PR adds automated tests for the GET / route in the 'api/v2/verifyaccess/index.js' router, focusing on

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Changes

  • Added index.test.js which contains test cases for the verifyaccess router
  • Added Babel and Jest config to handle transcompilation between modules

Testing

Feature was tested locally. Test cases cover: valid authorization token, no authorization token, invalid authorization token, and invalid email.

Checklist

  • My branch name matches the format: <ticket-id>/<brief-description-of-change>
  • My PR name matches the format: [<ticket-id>] <brief-description-of-change>
  • I have added doc-comments to all new functions (JSDoc for JS and Docstrings for Python)
  • I have reviewed all of my code
  • My code only contains major changes related to my ticket

Screenshots/Video

Additional Notes

@@ -16,21 +16,32 @@
"express": "^5.0.1",
"express-rate-limit": "^7.4.0",
"google-auth-library": "^9.14.2",
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are conflicts in this file still. They will need to be resolved. I recommend just checking the lockfile out to the previous version and re-installing with merged dependencies to hopefully minimize the lockfile conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants