-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GV-64] write-tests-for-api-v2-verifyaccess-index-js #26
Open
paulinaai
wants to merge
7
commits into
main
Choose a base branch
from
GV-64/Write-tests-for-api-v2-verifyaccess-index-js
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[GV-64] write-tests-for-api-v2-verifyaccess-index-js #26
paulinaai
wants to merge
7
commits into
main
from
GV-64/Write-tests-for-api-v2-verifyaccess-index-js
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeetoToast
reviewed
Nov 20, 2024
Connor-Bernard
requested changes
Nov 26, 2024
api/package-lock.json
Outdated
@@ -16,21 +16,32 @@ | |||
"express": "^5.0.1", | |||
"express-rate-limit": "^7.4.0", | |||
"google-auth-library": "^9.14.2", | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are conflicts in this file still. They will need to be resolved. I recommend just checking the lockfile out to the previous version and re-installing with merged dependencies to hopefully minimize the lockfile conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Jira Ticket
Description
The PR adds automated tests for the GET / route in the 'api/v2/verifyaccess/index.js' router, focusing on
Type of Change
Changes
Testing
Feature was tested locally. Test cases cover: valid authorization token, no authorization token, invalid authorization token, and invalid email.
Checklist
<ticket-id>/<brief-description-of-change>
[<ticket-id>] <brief-description-of-change>
Screenshots/Video
Additional Notes