Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #52

Closed
wants to merge 3 commits into from
Closed

Update Makefile #52

wants to merge 3 commits into from

Conversation

20urc3
Copy link
Contributor

@20urc3 20urc3 commented Sep 15, 2024

Fixing the following error:

f1_c_fuzz.c: In function ‘gen_node_NAUGHTYSTRING’:
f1_c_fuzz.c:13366:53: warning: unpaired UTF-8 bidirectional control characters detected [-Wbidi-chars=]

20urc3 and others added 3 commits June 28, 2024 12:46
Fixing the following error:

f1_c_fuzz.c: In function ‘gen_node_NAUGHTYSTRING’:
f1_c_fuzz.c:13366:53: warning: unpaired UTF-8 bidirectional control characters detected [-Wbidi-chars=]
@20urc3
Copy link
Contributor Author

20urc3 commented Sep 15, 2024

Fixes #51

@h1994st
Copy link
Collaborator

h1994st commented Sep 17, 2024

@20urc3 Thanks for the pull request.

Could you take a look at the error?

cc1: error: ‘-Wno-error=bidi-chars’: no option ‘-Wbidi-chars’

-Wbidi-chars option was introduced in GCC 12. However, ubuntu-latest image used by Github Actions is Ubuntu 22.04, and the default GCC is 11.2.0 (doc). As mentioned in the doc, ubuntu-latest has GCC 10, 11, and 12 installed.

Regarding this pull request:

  • We should add a guard condition to check the GCC version before appending -Wno-error=bidi-chars option to C_FLAGS
  • We should also update the CMakeLists.txt to make both building scripts consistent
  • (Optional) We'd better update the CI configuration to test on different GCC versions via the matrix strategy

@h1994st h1994st added the bug Something isn't working label Sep 17, 2024
@20urc3
Copy link
Contributor Author

20urc3 commented Sep 20, 2024

Hi @h1994st
Yes you answered your question. The issue is the presence (or not) of this flag in the used version of GCC.

@h1994st h1994st changed the base branch from stable to dev September 21, 2024 07:02
@h1994st
Copy link
Collaborator

h1994st commented Sep 21, 2024

Hi @20urc3, could you help resolve the error in CI?

@20urc3 20urc3 closed this by deleting the head repository Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants