librasan: Simplify assembly patches #3192
Open
+48
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfdewith
force-pushed
the
assembly
branch
2 times, most recently
from
bbcb655 to
472b5b3
Compare
|
Nice. Let's land this. |
domenukk
reviewed
May 3, 2025
| [0xff, 0xe0].to_vec(), | ||
| let addr = destination.to_ne_bytes(); | ||
| #[rustfmt::skip] | ||
| let insns: &[&[u8]] = &[ |
There was a problem hiding this comment.
Random question @WorksButNotTested can't we also do dynasm here like we do in libafl_frida?
LibAFL/libafl_frida/src/cmplog_rt.rs
Line 198 in d3ddc8e
Would be more maintable than pasting random bytes, right?
There was a problem hiding this comment.
That's pretty nice actually, but dynasm doesn't support ARMv7 and PowerPC. We can migrate the supported architectures if you'd like.
There was a problem hiding this comment.
Yeah. Nobody loves powerpc! Just went with it as it was the lowest common denominator. Happy if you want to port the others though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@domenukk as per your comment in #3176, I've simplified the assembly patches a bit to remove the
Vecusage. Therustfmt::skipattributes are there to keep lines matching with the assembly code in the comments.Checklist
./scripts/precommit.shand addressed all comments