This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Client secret should not be mandatory #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also like to point out that the client secret and ID shouldn't be included in the body anyway. they should be encoded using HTTP basic auth. I have already reported this here and will be submitting a PR for this soon. #85 |
mattt
added a commit
that referenced
this pull request
Mar 2, 2015
|
Thanks, @OmarPedraza. Due to the changes in 412d256, a different change was required with e5c00d1. Look for this in the forthcoming release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was already reported some time ago, but those changes are disappeared after moving from AFOAuth2Client to AFOAuth2Manager.
I think it would be great to add it again.