Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #203

Merged
merged 4 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ repos:

# Standard hooks
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
rev: v4.6.0
hooks:
- id: check-merge-conflict
- id: end-of-file-fixer
Expand All @@ -26,7 +26,7 @@ repos:

# Check for spelling
- repo: https://github.com/codespell-project/codespell
rev: v2.2.6
rev: v2.3.0
hooks:
- id: codespell
args: ["-L", "tre"]
Expand All @@ -39,7 +39,7 @@ repos:

# Upgrade old Python syntax
- repo: https://github.com/asottile/pyupgrade
rev: v3.15.1
rev: v3.15.2
hooks:
- id: pyupgrade
args: [--py310-plus]
Expand All @@ -66,7 +66,7 @@ repos:

# Black format Python and notebooks
- repo: https://github.com/psf/black
rev: 24.3.0
rev: 24.4.2
hooks:
- id: black-jupyter

Expand All @@ -84,7 +84,7 @@ repos:

# Check types with mypy
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.9.0
rev: v1.10.0
hooks:
- id: mypy
args: ["--ignore-missing-imports", "--follow-imports", "skip", "--check-untyped-defs"]
Expand Down
1 change: 1 addition & 0 deletions acro/acro_stata_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ def run_output_command(command: str, varlist: list) -> str:
first element of varlist is output affected
rest (if relevant) is string passed to command.
"""
outcome = ""
if len(varlist) == 0:
return "syntax error: please pass the name of the output to be changed"

Expand Down
2 changes: 1 addition & 1 deletion test/test_initial.py
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ def test_crosstab_multiple_aggregate_function(data, acro):
assert (
output.summary == correct_summary
), f"\n{output.summary}\n should be \n{correct_summary}\n"
print(f"{output.output[0]['mean'][ 'R/G'].sum()}")
print(f"{output.output[0]['mean']['R/G'].sum()}")
correctval = 97383496.0
errmsg = f"{output.output[0]['mean']['R/G'].sum()} should be {correctval}"
assert correctval == output.output[0]["mean"]["R/G"].sum(), errmsg
Expand Down
Loading