Removing references to final score #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #259 +/- ##
============================================
Coverage 99.37% 99.37%
============================================
Files 41 41
Lines 5596 5598 +2
============================================
+ Hits 5561 5563 +2
Misses 35 35 ☔ View full report in Codecov by Sentry. |
…nto score_disclaimer
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
simonrnss
reviewed
Feb 21, 2024
| @@ -28,7 +28,7 @@ def get_test_report(): | |||
| json_formatted = { | |||
| "log_id": 1024, | |||
| "metadata": {"attack": "WorstCase"}, | |||
| "model_params": {"min_samples_leaf": 10}, | |||
| "model_params": {"min_samples_leaf": 2}, | |||
simonrnss
approved these changes
Feb 21, 2024
…nto score_disclaimer
jim-smith
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all references to a final recommendation in the user stories. Removed references in both code and example outputs. All associated tests pass.