Allow dask #181
Merged
Allow dask #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…qual test_correlation and test_correlation_with_dim
…qual test_correlation and test_correlation_with_dim
BSchilperoort
approved these changes
Sep 26, 2024
CITATION.cff
Outdated
| @@ -38,6 +38,12 @@ authors: | |||
| given-names: Jannes | |||
| affiliation: "Vrije Universiteit Amsterdam" | |||
|
|
|||
| - | |||
There was a problem hiding this comment.
Suggested change
| - | |
| - |
the other dashes are less indented. not sure if it matters
| @@ -35,6 +35,7 @@ classifiers = [ | |||
| "Programming Language :: Python :: 3.11", | |||
| ] | |||
| dependencies = [ | |||
| "dask", | |||
There was a problem hiding this comment.
Is it required as dependency? The code runs fine without dask right?
There was a problem hiding this comment.
Good point, I'll check it without and see if it still works.
There was a problem hiding this comment.
I added dask back in as the tests broke on github actions after removing, so perhaps it is needed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from work from #176, making sure tests and formatting pass. Currently sonarcloud test is failing, probably due to changes on their end (issue #182), which we plan to fix in a future pull request.