-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read edm4hep #1371
base: master
Are you sure you want to change the base?
Read edm4hep #1371
Conversation
9dd2fbe
to
0969e1f
Compare
Test Results 14 files 14 suites 5h 26m 27s ⏱️ Results for commit 5906930. ♻️ This comment has been updated with latest results. |
db8bfbe
to
fa9431d
Compare
That GeneratorInfo is not yet written to EDM4hep files? |
c7a9ec0
to
818d1f6
Compare
Not consistently, i.e. if at all currently only with files that are produced via |
m_directAccess = true; | ||
} | ||
|
||
void EDM4hepFileReader::registerRunParameters() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will inadvertently mix "file level" metadata and run parameters for the output, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it would do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to keep them separated? E.g. by attaching the metadata frame to some entity as an extension and then writing it out again as a whole in the output if it is present?
3beea52
to
60603ac
Compare
60603ac
to
1e71124
Compare
1a9cace
to
5906930
Compare
BEGINRELEASENOTES
ENDRELEASENOTES
[x] Also ingest GeneratorInfo(to be done later Add GeneratorInfo to EDM4hepReader #1373)