Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract lambda to named function in monai transforms for dataloader #307

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

iamrjgs
Copy link
Contributor

@iamrjgs iamrjgs commented Oct 7, 2024

Description

Pickling of lambda functions is not supported in Windows, causing issue with get_features when iterating over dataset. Extraction of lambda x: x["image_path"].as_tensor() into named function called image_as_tensor on get_transforms sidesteps the issue.

Change adds support for running get_features on Windows 10.

See here: https://discuss.pytorch.org/t/cant-pickle-local-object-dataloader-init-locals-lambda/31857

Related Issue

#306

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • [x ] 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • [x ] I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Summary by CodeRabbit

  • New Features

    • Introduced a new function to convert image paths to tensor representations, enhancing the transformation process.
  • Improvements

    • Streamlined transformation logic by replacing inline functions with a dedicated method for better readability and maintainability.

Pickling of lambda functions is not supported in Windows, causing issue with get_features when iterating over dataset. Extraction of lambda x: x["image_path"].as_tensor() into named function called image_as_tensor on get_transforms sidesteps the issue.
Copy link

coderabbitai bot commented Oct 7, 2024

Walkthrough

The changes introduce a new function, image_as_tensor, in the fmcib/preprocessing/__init__.py file. This function converts an image path into a tensor and is used within the get_transforms function, replacing an inline lambda function that performed the same task. The modifications aim to enhance the readability and maintainability of the code by centralizing the tensor conversion logic without altering existing function signatures or control flow.

Changes

File Path Change Summary
fmcib/preprocessing/init.py Added image_as_tensor(x) function to convert image path to tensor, replacing lambda in get_transforms.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant get_transforms
    participant image_as_tensor

    User->>get_transforms: Request transformation
    get_transforms->>image_as_tensor: Convert image path to tensor
    image_as_tensor-->>get_transforms: Return tensor
    get_transforms-->>User: Return transformed data
Loading

🐰 In the meadow where bunnies play,
A function new has come to stay.
With tensors bright, they hop and cheer,
For clarity blooms, the path is clear.
No more lambdas, just joy and fun,
In code we trust, our work is done! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 938822c and 3d2014e.

📒 Files selected for processing (1)
  • fmcib/preprocessing/__init__.py (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • fmcib/preprocessing/init.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@surajpaib
Copy link
Member

@iamrjgs Thank you for proposing this PR! I will merge this and closed the associated issue

@surajpaib surajpaib merged commit 029da30 into AIM-Harvard:master Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants