-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract lambda to named function in monai transforms for dataloader #307
Conversation
Pickling of lambda functions is not supported in Windows, causing issue with get_features when iterating over dataset. Extraction of lambda x: x["image_path"].as_tensor() into named function called image_as_tensor on get_transforms sidesteps the issue.
WalkthroughThe changes introduce a new function, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant get_transforms
participant image_as_tensor
User->>get_transforms: Request transformation
get_transforms->>image_as_tensor: Convert image path to tensor
image_as_tensor-->>get_transforms: Return tensor
get_transforms-->>User: Return transformed data
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@iamrjgs Thank you for proposing this PR! I will merge this and closed the associated issue |
Description
Pickling of lambda functions is not supported in Windows, causing issue with get_features when iterating over dataset. Extraction of lambda x: x["image_path"].as_tensor() into named function called image_as_tensor on get_transforms sidesteps the issue.
Change adds support for running get_features on Windows 10.
See here: https://discuss.pytorch.org/t/cant-pickle-local-object-dataloader-init-locals-lambda/31857
Related Issue
#306
Type of Change
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.make codestyle
.Summary by CodeRabbit
New Features
Improvements