-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
리뷰용 pr입니다. #64
base: review-base
Are you sure you want to change the base?
리뷰용 pr입니다. #64
Changes from all commits
bae0953
c08d76c
8a24038
428ed5e
a2c8ada
3386a03
3367549
cc5e106
6b36dc6
59e1944
c1bceca
667ab03
25641ac
5629016
50cd530
4bdc15f
27eafef
bbfecb1
e9450a2
98d26d9
d007a03
96a2354
99826c4
820b4bc
01719cf
24c475b
34d1438
8d33eda
a270858
2aa590d
e3faf90
c14b654
7d55a0f
054d266
95347d0
2508432
15b7c6d
5966a2e
bb2b5e4
ee7bbab
3b45050
4a71d87
2b7721e
1b0f431
bf25f49
b188654
6c5dc0c
b47ad18
f3c59b1
f166acd
ebe3d54
b2e8e87
dcd1433
69a69af
4f7c62a
077a083
82349c4
5b0aa2e
8a14a36
e136980
e7dafe0
d45ec7e
c7ad265
54cde98
297d324
a582b6b
ee380ac
25f6fb6
051fac5
5fd094a
4dded78
9a8d7be
c86e058
4dc55f4
77799b0
dbcfb42
ad33e6f
d5e1b33
63f736f
3604353
b622a19
d58819d
0cb7e82
7f372db
7ec0126
9750469
d1fd5dd
8b394a4
b5d6895
3493edb
a0fd4a2
0f94a12
bc1dbc0
c0ce6eb
8cebceb
8ca3e26
fed1c30
0a9aa55
4d687a7
3e7809a
282061c
3da7e92
47b2b13
a9477ce
94b9059
a1f20d8
46b87c0
972f162
bd5c57c
5b65a56
554519a
b53a10c
e4e2818
e1886df
230895e
1a6d70c
c79592d
4bd598d
4e5a63d
d7a6d67
f69f645
b58d13c
f83c238
8f6274b
923eb93
e0cc45f
8b81bf4
e4bb24e
200ad9b
1453faf
b9843bb
ccf9959
54b0830
ea7fca4
4967e77
e738f2f
5749a40
dc3a731
092ceeb
7c09dfb
79925b1
09e41fa
04c964f
a9906de
2111e8c
424e1ab
359db83
1803e9c
db91b24
49eb882
9725a49
334503a
f770012
a9d2a25
18785bf
3b47af8
1e54cea
a66e509
29bbad8
ca3e45c
5f82cc0
6d508d5
e63d768
8318b36
ac66958
1c7adc9
b0b5842
3f1d308
b7583d3
b05a3c1
eed4008
e4702cc
5b83485
46ae430
7829305
e784c3c
f1ee10c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
module.exports = { | ||
env: { | ||
browser: true, | ||
es2021: true, | ||
}, | ||
extends: [ | ||
'eslint:recommended', | ||
'plugin:@typescript-eslint/recommended', | ||
'plugin:react/recommended', | ||
], | ||
overrides: [ | ||
{ | ||
env: { | ||
node: true, | ||
}, | ||
files: ['.eslintrc.{js,cjs}'], | ||
parserOptions: { | ||
sourceType: 'script', | ||
}, | ||
}, | ||
], | ||
parser: '@typescript-eslint/parser', | ||
parserOptions: { | ||
ecmaVersion: 'latest', | ||
sourceType: 'module', | ||
}, | ||
plugins: ['@typescript-eslint', 'react'], | ||
rules: { | ||
'react/react-in-jsx-scope': 'off', | ||
'react/jsx-curly-brace-presence': 'error', | ||
'react/prop-types': 'off', | ||
'@typescript-eslint/no-unused-vars': 'off', // 이 줄을 추가하여 규칙 해제 | ||
}, | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
--- | ||
name: Custom issue template | ||
about: Describe this issue template's purpose here. | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
## 목적 🪄 | ||
> 어떤 작업을 위한 이슈인지 설명해주세요. | ||
|
||
<br> | ||
<br> | ||
|
||
## 작업 내용 💻 | ||
> 이번 PR에서 작업할 내용을 간략히 설명해주세요. (이미지 첨부 환영) | ||
|
||
|
||
<br> | ||
<br> | ||
|
||
## 스크린샷 📸 (선택) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
name: 이슈 생성 템플릿 | ||
about: 해당 이슈 생성 템플릿을 이용하여 이슈를 생성해주세요 | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
## (제목) | ||
### (페이지) | ||
- [ ] 구현내용1 | ||
- [ ] 구현내용2 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
## 🪄 목적 | ||
|
||
> 관련 이슈 : # | ||
|
||
<br /> | ||
<br /> | ||
|
||
## 💻 상세 작업 내용 | ||
|
||
> 이번 PR에서 작업한 내용을 간략히 설명해주세요. | ||
|
||
- | ||
|
||
<br /> | ||
<br /> | ||
|
||
## 📸 스크린샷 | ||
|
||
<br /> | ||
<br /> | ||
|
||
## 👼🏻 리뷰 요구사항 (선택) | ||
|
||
> 리뷰어가 특별히 봐줬으면 하는 부분이 있다면 작성해주세요. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ | |
|
||
# misc | ||
.DS_Store | ||
.env | ||
.env.local | ||
.env.development.local | ||
.env.test.local | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
yarn commitlint --edit $1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
yarn |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
v20.11.1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"singleQuote": true, | ||
"jsxSingleQuote": false, | ||
"trailingComma": "es5", | ||
"printWidth": 100, | ||
"tabWidth": 2, | ||
"semi": true, | ||
"endOfLine": "auto", | ||
"arrowParens": "avoid", | ||
"bracketSpacing": true | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1,16 @@ | ||
# Getting Started with Create React App | ||
## 끄적끄적 FE | ||
|
||
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
### FE용 세팅 | ||
|
||
## Available Scripts | ||
``` | ||
1. 노드버전을 .nvmrc 파일에 명시된 버전으로 세팅 | ||
nvm use (만약에 본인의 개발환경에 .nvmrc에 명시된 node 버전이 없다면 nvm install을 진행하고 나서 nvm use를 해야함) | ||
|
||
In the project directory, you can run: | ||
2. 설치 | ||
yarn install | ||
|
||
### `yarn start` | ||
3. pretiter & eslint 에디터 설정 | ||
각자 에디터에 맞게 설정 | ||
|
||
Runs the app in the development mode.\ | ||
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. | ||
|
||
The page will reload if you make edits.\ | ||
You will also see any lint errors in the console. | ||
|
||
### `yarn test` | ||
|
||
Launches the test runner in the interactive watch mode.\ | ||
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. | ||
|
||
### `yarn build` | ||
|
||
Builds the app for production to the `build` folder.\ | ||
It correctly bundles React in production mode and optimizes the build for the best performance. | ||
|
||
The build is minified and the filenames include the hashes.\ | ||
Your app is ready to be deployed! | ||
|
||
See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. | ||
|
||
### `yarn eject` | ||
|
||
**Note: this is a one-way operation. Once you `eject`, you can’t go back!** | ||
|
||
If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | ||
|
||
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own. | ||
|
||
You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it. | ||
|
||
## Learn More | ||
|
||
You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started). | ||
|
||
To learn React, check out the [React documentation](https://reactjs.org/). | ||
4. 앱을 실행하려면 yarn start 명령어 입력 | ||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
module.exports = { | ||
extends: ['@commitlint/config-conventional'], | ||
rules: { | ||
'header-pattern': [2, 'always', /^\[#(\d+)\]\s(\w+):\s(.+)$/], | ||
'header-max-length': [2, 'always', 72], | ||
'type-enum': [ | ||
2, | ||
'always', | ||
[ | ||
'feat', // 기능 (새로운 기능) | ||
'fix', // 버그 수정 | ||
'docs', // 문서 (문서 추가, 수정, 삭제) | ||
'style', // 스타일 (코드 포맷팅, 세미콜론 추가: 비즈니스 로직에 변경 없음) | ||
'refactor', // 리팩토링 (프로덕션 코드 수정이 없는 경우) | ||
'perf', // 성능 개선 | ||
'test', // 테스트 추가, 수정 | ||
'chore', // 기타 변경사항 (빌드 스크립트 수정 등) | ||
'revert', // 커밋 되돌리기 | ||
'build', // 빌드 관련 변경사항 (npm, yarn 등) | ||
], | ||
], | ||
}, | ||
parserPreset: { | ||
parserOpts: { | ||
headerPattern: /^\[#(\d+)\]\s(\w+):\s(.+)$/, | ||
headerCorrespondence: ['ticket', 'type', 'subject'], | ||
}, | ||
}, | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,24 +3,54 @@ | |
"version": "0.1.0", | ||
"private": true, | ||
"dependencies": { | ||
"@testing-library/jest-dom": "^5.14.1", | ||
"@blocknote/core": "^0.15.5", | ||
"@blocknote/mantine": "^0.15.5", | ||
"@blocknote/react": "^0.15.5", | ||
"@emotion/react": "^11.13.3", | ||
"@emotion/styled": "^11.13.0", | ||
"@mui/material": "^6.0.2", | ||
"@tanstack/react-query": "^5.52.1", | ||
"@tanstack/react-query-devtools": "^5.52.1", | ||
"@testing-library/jest-dom": "^6.4.8", | ||
"@testing-library/react": "^13.0.0", | ||
"@testing-library/user-event": "^13.2.1", | ||
"@types/jest": "^27.0.1", | ||
"@types/jest": "^29.5.12", | ||
"@types/node": "^16.7.13", | ||
"@types/react": "^18.0.0", | ||
"@types/react-dom": "^18.0.0", | ||
"@types/react-modal": "^3.16.3", | ||
"@types/styled-components": "^5.1.34", | ||
"aos": "^2.3.4", | ||
"axios": "^1.7.5", | ||
"date-fns": "^3.6.0", | ||
"framer-motion": "^11.3.8", | ||
"gsap": "^3.12.5", | ||
"jotai": "^2.9.2", | ||
"react": "^18.3.1", | ||
"react-autosize-textarea": "^7.1.0", | ||
"react-beautiful-dnd": "^13.1.1", | ||
"react-datepicker": "^7.3.0", | ||
"react-dom": "^18.3.1", | ||
"react-scripts": "5.0.1", | ||
"typescript": "^4.4.2", | ||
"react-icons": "^5.2.1", | ||
"react-intersection-observer": "^9.13.0", | ||
"react-modal": "^3.16.1", | ||
"react-paginate": "^8.2.0", | ||
"react-router-dom": "^6.25.1", | ||
"react-scripts": "^5.0.1", | ||
"react-textarea-autosize": "^8.5.3", | ||
"simplex-noise": "^4.0.2", | ||
"styled-components": "^6.1.12", | ||
"styled-reset": "^4.5.2", | ||
"three": "^0.167.0", | ||
"typescript": "^5.5.3", | ||
"web-vitals": "^2.1.0" | ||
}, | ||
"scripts": { | ||
"start": "react-scripts start", | ||
"build": "react-scripts build", | ||
"test": "react-scripts test", | ||
"eject": "react-scripts eject" | ||
"eject": "react-scripts eject", | ||
Comment on lines
48
to
+52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 프로젝트를 CRA로 만드신것같네용 일단 플젝 진행중이긴 하니 마이그레이션이 필수는 아니지만, 나중에 시간 여유 생기면 webpack같은 번들러로 프로젝트 세팅 직접 해보시는거 추천드릴게요! 그게 아니라 cra처럼 가볍게 프로젝트 세팅이 필요한 상황이라면, create vite를 사용하는걸 추천드려요! |
||
"prepare": "husky" | ||
}, | ||
"eslintConfig": { | ||
"extends": [ | ||
|
@@ -39,5 +69,28 @@ | |
"last 1 firefox version", | ||
"last 1 safari version" | ||
] | ||
} | ||
}, | ||
"devDependencies": { | ||
"@commitlint/cli": "^19.3.0", | ||
"@commitlint/config-conventional": "^19.2.2", | ||
"@types/aos": "^3.0.7", | ||
"@types/axios": "^0.14.0", | ||
"@types/gsap": "^3.0.0", | ||
"@types/mocha": "^10.0.7", | ||
"@types/react-beautiful-dnd": "^13.1.8", | ||
"@types/react-datepicker": "^7.0.0", | ||
"@types/testing-library__jest-dom": "^6.0.0", | ||
"@types/three": "^0.166.0", | ||
"@types/unist": "^3.0.3", | ||
"@types/webxr": "^0.5.19", | ||
"@typescript-eslint/eslint-plugin": "^7.16.1", | ||
"@typescript-eslint/parser": "^7.16.1", | ||
"eslint": "^8.57.0", | ||
"eslint-config-prettier": "^9.1.0", | ||
"eslint-plugin-prettier": "^5.2.1", | ||
"eslint-plugin-react": "^7.34.4", | ||
"husky": "^9.1.1", | ||
"prettier": "3.3.3" | ||
}, | ||
"proxy": "https://dev.kkeujeok.store" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependency와 devDependency에 대한 학습이 필요해보여요!
testing-library같은 의존성이나, @types같은 친구들이 dependencies에 들어간 이유가 있을까요!?
한번 알아보는거 추천드립니당