Put loop over iter in MLMG smooth #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
reviewed
Mar 10, 2025
| */ | ||
| virtual void smooth (int amrlev, int mglev, MF& sol, const MF& rhs, | ||
| bool skip_fillboundary=false) const = 0; | ||
| bool skip_fillboundary=false, int niter=1) const = 0; |
There was a problem hiding this comment.
Since we are changing the interface here, let's make both parameters non-optional. Having optional parameters in virtual functions is said to be an anti-pattern.
WeiqunZhang
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional background
Checklist
The proposed changes: