MAC projector with Robin BCs needs initialization every time. The #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underlying solver, (EB)MLABecLaplacian, is not save for reuse with Robin BCs.
WeiqunZhang
reviewed
Mar 4, 2024
Projections/hydro_MacProjector.cpp
Outdated
| @@ -212,6 +212,7 @@ MacProjector::setLevelBC (int amrlev, const MultiFab* levelbcdata, const MultiFa | |||
| "setDomainBC must be called before setLevelBC"); | |||
| m_linop->setLevelBC(amrlev, levelbcdata, robin_a, robin_b, robin_f); | |||
| m_needs_level_bcs[amrlev] = false; | |||
| m_needs_init = true; // Solver is not safe for reuse with Robin BC | |||
There was a problem hiding this comment.
Maybe we should only do this when the robin_* pointers are non null.
There was a problem hiding this comment.
Simply checking on robin_a should work right? MLABecLap will fail if only robin_a is non-null, right?
WeiqunZhang
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
underlying solver, (EB)MLABecLaplacian, is not safe for reuse with Robin BCs.