Resuse macproj w robin and Update Docs #126
Conversation
underlying solver, (EB)MLABecLaplacian, is not save for reuse with Robin BCs.
instead of updateBeta.
Projections/hydro_MacProjector.cpp
Outdated
| @@ -210,11 +234,12 @@ MacProjector::setLevelBC (int amrlev, const MultiFab* levelbcdata, const MultiFa | |||
| { | |||
| AMREX_ALWAYS_ASSERT_WITH_MESSAGE(!m_needs_domain_bcs, | |||
| "setDomainBC must be called before setLevelBC"); | |||
| AMREX_ALWAYS_ASSERT_WITH_MESSAGE( | |||
| !robin_a || (robin_a && !m_abeclap), | |||
| "MacProjector::setLevelBC(): Projection only tested for case of EB separated mixed BC."); | |||
There was a problem hiding this comment.
I don't think we can add this assertion. What if someone has already been using Robin BC for non-EB case?
There was a problem hiding this comment.
In fact, the Robin BC was first developed because someone requested the feature for non-EB cases.
There was a problem hiding this comment.
Fair enough (although I don't think the way the MAC Projector was before pr 122 would allow for robin bcs). I've just not tested the Mac Projector with anything other than EB separated cases. But if you say it's fine, then it's fine.
There was a problem hiding this comment.
In principle, all one needed to do before pr 122 was getLinOp.
There was a problem hiding this comment.
I tried that first, but the MacProjector has this private member flag m_needs_level_bcs that made a using getLinOp ineffective because there would be a subsequent call to setLevelBC(ilev, nullptr) in project. ... doesn't matter now though. thanks for merging
Doc updates in conjunction with AMReX PR 3797