-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix use old style include directories for filters #442
Merged
Ryanf55
merged 2 commits into
ANYbotics:rolling
from
Ryanf55:bugfix-use-old-style-for-filters
Feb 18, 2024
Merged
Bugfix use old style include directories for filters #442
Ryanf55
merged 2 commits into
ANYbotics:rolling
from
Ryanf55:bugfix-use-old-style-for-filters
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
srmainwaring
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified on macOS.
@Mergifyio backport iron |
✅ Backports have been created
|
@Mergifyio backport humble |
✅ Backports have been created
|
Ryanf55
added a commit
that referenced
this pull request
Feb 18, 2024
Bugfix use old style include directories for filters (backport #442)
Ryanf55
added a commit
that referenced
this pull request
Feb 18, 2024
Bugfix use old style include directories for filters (backport #442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use old-style CMake variables as a patch till this upstream issue makes it into humble binaries: ros/filters#70
Cause
https://github.com/ANYbotics/grid_map/pull/404/files#diff-217de7f0d7eec88dce2cada8716bd30748cf9ad20d1211c56501a2acb56666bbL28
This PR forgot to add the include directories from
filters
, probably because there were no targets. I'm not sure how it builds on rolling and not humble. This patch can be replaced with a propertarget_link_libraries
call soon.Effect
It's blocking CI from passing in this PR: https://github.com/ANYbotics/grid_map/actions/runs/7943206475/job/21687293385?pr=440#step:6:25
Upstream variables
You can see the variable we need to use is
filters_INCLUDE_DIRS