Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ament_export_targets in grid_map_costmap_2d (backport #424) #449

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 20, 2024

This is an automatic backport of pull request #424 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Feb 26, 2024

Error:

  Target "grid_map_costmap_2d-test" links to target
  "nav2_costmap_2d::nav2_costmap_2d_core" but the target was not found.

@Ryanf55 Ryanf55 added the ros2 Affects ROS 2 label Jul 28, 2024
@Ryanf55 Ryanf55 added this to the 2.2.0 milestone Jul 28, 2024
* Link to exported namespace targets when possible
* And use INTERFACE targets

Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit c0c7ef1)
@Ryanf55 Ryanf55 force-pushed the mergify/bp/humble/pr-424 branch from 9d8467e to 6c5c09f Compare July 28, 2024 17:51
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jul 28, 2024

Error:

  Target "grid_map_costmap_2d-test" links to target
  "nav2_costmap_2d::nav2_costmap_2d_core" but the target was not found.

Fixed by waiting for upstream binaries to come in.

@Ryanf55 Ryanf55 merged commit 69c100f into humble Jul 28, 2024
2 checks passed
@mergify mergify bot deleted the mergify/bp/humble/pr-424 branch July 28, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros2 Affects ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant