Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROS 2][grid_map_core] Code enhancements from master 6ddff74 #503

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

[ROS 2][grid_map_core] Code enhancements from master 6ddff74 #503

wants to merge 2 commits into from

Conversation

kjalloul-anybotics
Copy link

Cherry-picked commit 6ddff74 (No PR)

Includes:

  • Adding Color union
  • Removing unused function getIndicesForRegion
  • Using static_cast instead of c-style cast
  • Fixing unused function parameters

@kjalloul-anybotics
Merge branch 'fix/grid_map_core_remove_compiler_warnings' into 'master'
66f6fb7 
[grid_map_core] Remove compiler warnings

GitOrigin-RevId: 593af35e98d1d24b28f8aaedbc18d96e99f861cf
@kjalloul-anybotics
Copy link
Author

@Ryanf55 Not sure if removing getIndicesForRegion counts as a breaking change here.

The functions were already commented out in GridMapMath.cpp and unused in the repository.

@kjalloul-anybotics kjalloul-anybotics self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryanf55 Ryanf55 Awaiting requested review from Ryanf55

Assignees

@kjalloul-anybotics kjalloul-anybotics

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kjalloul-anybotics