-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split and document avifParseCodecConfiguration() #1493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I suggest some changes. Regarding the period after a section number, I wonder if this is a regional difference.
The advantages of some of the function splits are not obvious to me. Is this pull request setting up for the Slim HEIF code, so that the function splits will make more sense when the Slim HEIF code is added?
Mirror the changes of read.c to write.c too.
29a5979
to
b3a2783
Compare
In the specification there is a trailing dot after section numbers so I repeated that here.
Yes, this is partly to simplify #1432. |
Mirror the changes of read.c to write.c too.
Also nits.
This is partly to simplify #1432.