Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and document avifParseCodecConfiguration() #1493

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Aug 3, 2023

Mirror the changes of read.c to write.c too.
Also nits.

This is partly to simplify #1432.

Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I suggest some changes. Regarding the period after a section number, I wonder if this is a regional difference.

The advantages of some of the function splits are not obvious to me. Is this pull request setting up for the Slim HEIF code, so that the function splits will make more sense when the Slim HEIF code is added?

src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/write.c Outdated Show resolved Hide resolved
src/write.c Outdated Show resolved Hide resolved
src/write.c Outdated Show resolved Hide resolved
@y-guyon
Copy link
Collaborator Author

y-guyon commented Aug 11, 2023

Regarding the period after a section number, I wonder if this is a regional difference.

In the specification there is a trailing dot after section numbers so I repeated that here.

The advantages of some of the function splits are not obvious to me. Is this pull request setting up for the Slim HEIF code, so that the function splits will make more sense when the Slim HEIF code is added?

Yes, this is partly to simplify #1432.

@y-guyon y-guyon merged commit fa11395 into AOMediaCodec:main Aug 11, 2023
@y-guyon y-guyon deleted the split_parse_av1c branch August 11, 2023 08:48
src/read.c Show resolved Hide resolved
src/write.c Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants