Refactor 'alpha' bool to an 'itemCategory' enum value. #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-guyon
reviewed
Aug 9, 2023
| @@ -262,8 +271,8 @@ AVIF_ARRAY_DECLARE(avifDecodeSampleArray, avifDecodeSample, sample); | |||
| typedef struct avifCodecDecodeInput | |||
There was a problem hiding this comment.
Just a thought: avifCodecDecodeInput could be moved to read.c
There was a problem hiding this comment.
Indeed, but I think it should be done in another PR.
src/write.c
Outdated
| uint16_t * topLevelItemID) | ||
| { | ||
| const uint32_t cellCount = gridCols * gridRows; | ||
| const char * infeName = alpha ? "Alpha" : "Color"; | ||
| const char * infeName = (itemType == AVIF_ITEM_ALPHA) ? "Alpha" : "Color"; |
There was a problem hiding this comment.
I saw avifGetErrorForItemType() and I am wondering if there should also be avifGetInfeNameForItemType(), avifIsItemTypeAlpha() etc.
Can be done later of course.
There was a problem hiding this comment.
It's only used in one place so I think it's fine as is?
maryla-uc
changed the title
y-guyon
approved these changes
Aug 10, 2023
wantehchang
added a commit
to wantehchang/libavif
that referenced
this pull request
Sep 1, 2023
avifItemCategory was originally named avifItemType in AOMediaCodec#1499.
y-guyon
pushed a commit
that referenced
this pull request
Sep 12, 2023
avifItemCategory was originally named avifItemType in #1499.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor will be useful when adding gain maps.