Make the gainMap member of avifImage a pointer. #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows adding members in the future without breaking the ABI.
vrabaud
approved these changes
Nov 23, 2023
| @@ -57,13 +57,13 @@ avifResult PrintMetadataCommand::Run() { | |||
| << decoder->diag.error << ")\n"; | |||
| return result; | |||
| } | |||
| if (!decoder->gainMapPresent) { | |||
| if (!decoder->gainMapPresent || decoder->image->gainMap == nullptr) { | |||
There was a problem hiding this comment.
gainMapPresent coule be true and decoder->image->gainMap nullptr?
There was a problem hiding this comment.
In theory no. Changed to an assert.
| @@ -1208,8 +1208,10 @@ static avifResult avifValidateGrid(uint32_t gridCols, | |||
| const avifImage * bottomRightCell = cellImages[cellCount - 1]; | |||
| #if defined(AVIF_ENABLE_EXPERIMENTAL_GAIN_MAP) | |||
| if (validateGainMap) { | |||
| firstCell = firstCell->gainMap.image; | |||
| bottomRightCell = bottomRightCell->gainMap.image; | |||
| assert(firstCell->gainMap && firstCell->gainMap->image); | |||
There was a problem hiding this comment.
Just wondering if that can never happen and whether AVIF_CHECKRES should be used
There was a problem hiding this comment.
No the caller should only call the function with validateGainMap if there is a gain map. I think defensive programming is not useful in this instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows adding members in the future without breaking the ABI.