Remove dependency on AVM internal headers. #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releases are unfrequent anyway so we might as well use the proper values and not the enums.
y-guyon
approved these changes
Jan 11, 2024
wantehchang
reviewed
Jan 11, 2024
| for (int i = 1; i < RESTORE_SWITCHABLE_TYPES; ++i) { | ||
| if (DEF_UV_LR_TOOLS_DISABLE_MASK & (1 << i)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
DEF_UV_LR_TOOLS_DISABLE_MASK is equal to (1 << 3). So we execute the continue statement when i = 3.
So this for loop should read 5 - 1 - 1 bits. This doesn't match the new code. Which one is right? Or did I make a mistake in the analysis?
There was a problem hiding this comment.
Indeed, you are totally right: #1931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releases are unfrequent anyway so we might as well use the proper values and not the enums.