Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libjpeg-turbo in ext/libjpeg.cmd #1994

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Feb 6, 2024

@@ -9,6 +9,7 @@
/ext/gpac
/ext/libargparse
/ext/libjpeg
/ext/libjpeg-turbo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete the /ext/libjpeg line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I could leave it for now. If users update their local repositories instead of cloning fresh ones, it will avoid an eventual libjpeg entry popping into git status.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the ext/libjpeg entry in the git status output could remind the user to delete the directory. That seems good.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the ext/libjpeg entry in the git status output could remind the user to delete the directory.

Good point.
The case I had in mind was switching between the main and v1.0.x branches while keeping both ext/libjpeg and ext/libjpeg-turbo.

That seems good.

Not sure what this refers to.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant it seems good to have the ext/libjpeg entry in the git status output, because it could remind the user to delete the directory.

Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

ext/libjpeg.cmd Outdated Show resolved Hide resolved
cmake/Modules/LocalJpeg.cmake Outdated Show resolved Hide resolved
@@ -9,6 +9,7 @@
/ext/gpac
/ext/libargparse
/ext/libjpeg
/ext/libjpeg-turbo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the ext/libjpeg entry in the git status output could remind the user to delete the directory. That seems good.

@y-guyon y-guyon merged commit 1862235 into AOMediaCodec:main Feb 8, 2024
19 checks passed
@y-guyon y-guyon deleted the libjpeg_turbo branch February 8, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants