-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libjpeg-turbo in ext/libjpeg.cmd #1994
Conversation
@@ -9,6 +9,7 @@ | |||
/ext/gpac | |||
/ext/libargparse | |||
/ext/libjpeg | |||
/ext/libjpeg-turbo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete the /ext/libjpeg
line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I could leave it for now. If users update their local repositories instead of cloning fresh ones, it will avoid an eventual libjpeg
entry popping into git status
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing the ext/libjpeg
entry in the git status
output could remind the user to delete the directory. That seems good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing the
ext/libjpeg
entry in thegit status
output could remind the user to delete the directory.
Good point.
The case I had in mind was switching between the main
and v1.0.x
branches while keeping both ext/libjpeg
and ext/libjpeg-turbo
.
That seems good.
Not sure what this refers to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant it seems good to have the ext/libjpeg
entry in the git status
output, because it could remind the user to delete the directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
@@ -9,6 +9,7 @@ | |||
/ext/gpac | |||
/ext/libargparse | |||
/ext/libjpeg | |||
/ext/libjpeg-turbo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing the ext/libjpeg
entry in the git status
output could remind the user to delete the directory. That seems good.
BUG=oss-fuzz:66492
BUG=oss-fuzz:66434
BUG=oss-fuzz:66425