Speed rgbtoyuvtest up

[y-guyon]

Please review only the second commit.

[vrabaud]

Please keep the removed tests: maybe DISABLE them.

[y-guyon]

Please keep the removed tests: maybe DISABLE them.

They are already tested with min/max rgb values:

libavif/tests/gtest/avifrgbtoyuvtest.cc

Lines 296 to 349 in b10d269

	// Exhaustive settings
	// These tests would generate too many GoogleTest instances as parameterized
	// tests (TEST_P) so loops are used instead.
	TEST(RGBToYUVTest, ExhaustiveSettings) {
	// Coverage of all configurations with all min/max input combinations.
	for (int rgb_depth : {8, 10, 12, 16}) {
	for (int yuv_depth : {8, 10, 12, 16}) {
	for (avifRGBFormat rgb_format :
	{AVIF_RGB_FORMAT_RGB, AVIF_RGB_FORMAT_RGBA, AVIF_RGB_FORMAT_ARGB,
	AVIF_RGB_FORMAT_BGR, AVIF_RGB_FORMAT_BGRA, AVIF_RGB_FORMAT_ABGR}) {
	for (avifPixelFormat yuv_format :
	{AVIF_PIXEL_FORMAT_YUV444, AVIF_PIXEL_FORMAT_YUV422,
	AVIF_PIXEL_FORMAT_YUV420, AVIF_PIXEL_FORMAT_YUV400}) {
	for (avifRange yuv_range : {AVIF_RANGE_LIMITED, AVIF_RANGE_FULL}) {
	for (decltype(AVIF_MATRIX_COEFFICIENTS_IDENTITY)
	matrix_coefficients : {AVIF_MATRIX_COEFFICIENTS_IDENTITY,
	AVIF_MATRIX_COEFFICIENTS_BT601}) {
	if (matrix_coefficients == AVIF_MATRIX_COEFFICIENTS_IDENTITY &&
	yuv_format != AVIF_PIXEL_FORMAT_YUV444) {
	// See avifPrepareReformatState().
	continue;
	}
	for (avifChromaDownsampling chroma_downsampling :
	{AVIF_CHROMA_DOWNSAMPLING_AUTOMATIC,
	AVIF_CHROMA_DOWNSAMPLING_FASTEST,
	AVIF_CHROMA_DOWNSAMPLING_BEST_QUALITY,
	AVIF_CHROMA_DOWNSAMPLING_AVERAGE,
	AVIF_CHROMA_DOWNSAMPLING_SHARP_YUV}) {
	if (chroma_downsampling == AVIF_CHROMA_DOWNSAMPLING_SHARP_YUV &&
	yuv_depth > 12) {
	// SharpYuvConvert() only supports YUV bit depths up to 12.
	continue;
	}
	ConvertWholeRange(
	rgb_depth, yuv_depth, rgb_format, yuv_format, yuv_range,
	static_cast<avifMatrixCoefficients>(matrix_coefficients),
	chroma_downsampling,
	/*add_noise=*/true,
	// Just try min and max values.
	/*rgb_step=*/(1u << rgb_depth) - 1u,
	// Barely check the results, this is mostly for coverage.
	/*max_abs_average_diff=*/(1u << rgb_depth) - 1u,
	/*min_psnr=*/5.0,
	// Avoid spam.
	/*log=*/false);
	}
	}
	}
	}
	}
	}
	}
	}

I do not think it is necessary to add a DISABLED test suite instantiation.