ext/dav1d.cmd: Add -Db_lundef=false to comments #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The need to use -Db_lundef=false with the sanitizers in Clang is documented in the following pages: https://clang.llvm.org/docs/AddressSanitizer.html#usage https://clang.llvm.org/docs/MemorySanitizer.html#usage If -Db_sanitize=<sanitizer> is used without -Db_lundef=false and the compiler is Clang, meson emits a warning message like this: ../tests/meson.build:31: WARNING: Trying to use address sanitizer on Clang with b_lundef. This will probably not work. Try setting b_lundef to false instead. Note: The change to ext/dav1d.cmd allows us to remove the "-v2" suffix (added in AOMediaCodec#2034) from the cache file names.
vrabaud
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need to use -Db_lundef=false with the sanitizers in Clang is documented in the following pages:
https://clang.llvm.org/docs/AddressSanitizer.html#usage
https://clang.llvm.org/docs/MemorySanitizer.html#usage
If -Db_sanitize= is used without -Db_lundef=false and the compiler is Clang, meson emits a warning message like this:
../tests/meson.build:31: WARNING: Trying to use address sanitizer on
Clang with b_lundef.
This will probably not work.
Try setting b_lundef to false instead.
Note: The change to ext/dav1d.cmd allows us to remove the "-v2" suffix (added in #2034) from the cache file names.