Do not export env variables, just assign to them. #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message made me first think all the variables are environment variables, but only CXXFLAGS is here. To distinguish the two you could make the non-constant/environment variables lowercase, but that's a cosmetic for another change. |
jzern
approved these changes
Feb 28, 2024
wantehchang
approved these changes
Feb 29, 2024
tests/oss-fuzz/build.sh
Outdated
| if [ "$SANITIZER" != "coverage" ] && [ "$SANITIZER" != "introspector" ] | ||
| then | ||
| export DAV1D_EXTRA_FLAGS="-Db_sanitize=$SANITIZER -Db_lundef=false" | ||
| DAV1D_EXTRA_FLAGS="-Db_sanitize=$SANITIZER -Db_lundef=false" |
There was a problem hiding this comment.
Optional: Since DAV1D_EXTRA_FLAGS has been initialized an empty string, we can append to it here.
tests/oss-fuzz/build.sh
Outdated
| export CXXFLAGS="${CXXFLAGS} -DFUZZTEST_COMPATIBILITY_MODE" | ||
| export EXTRA_CMAKE_FLAGS="-DAVIF_ENABLE_FUZZTEST=ON -DFUZZTEST_COMPATIBILITY_MODE=libfuzzer" | ||
| CXXFLAGS="${CXXFLAGS} -DFUZZTEST_COMPATIBILITY_MODE" | ||
| EXTRA_CMAKE_FLAGS="-DAVIF_ENABLE_FUZZTEST=ON -DFUZZTEST_COMPATIBILITY_MODE=libfuzzer" |
There was a problem hiding this comment.
Optional: We can also initialize EXTRA_CMAKE_FLAGS to an empty string before the if statement, and append to it here. This will allow us to get rid of the else branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have DAV1D_EXTRA_FLAGS and EXTRA_CMAKE_FLAGS be normal non-environment variables.
BUG=oss-fuzz:67122