Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-unix-static-sanitized #2054

Merged
merged 1 commit into from
Mar 14, 2024
Merged

ci-unix-static-sanitized #2054

merged 1 commit into from
Mar 14, 2024

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Mar 14, 2024

No description provided.

@y-guyon y-guyon merged commit c783651 into AOMediaCodec:main Mar 14, 2024
20 checks passed
@y-guyon y-guyon deleted the ci_test_all branch March 14, 2024 14:41

jobs:
build-static-sanitized:
runs-on: ubuntu-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this CI workflow. If this works on macos-latest, it would be good to add it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #2061

run: ninja
- name: Run AVIF Tests
working-directory: ./build
# ASAN_OPTIONS=allocator_may_return_null=1 may be necessary for address sanitizer.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it is necessary.

- name: Build aom
if: steps.cache-ext.outputs.cache-hit != 'true'
working-directory: ./ext
run: CC=clang CXX=clang++ CFLAGS=-fsanitize=${{ matrix.sanitizer }} CXXFLAGS=-fsanitize=${{ matrix.sanitizer }} LDFLAGS=-fsanitize=${{ matrix.sanitizer }} ./aom.cmd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: We can set environment variables using env. Please see if this works:

      run: ./aom.cmd
      env:
        CC: clang
        CXX: clang++
        CFLAGS: -fsanitize=${{ matrix.sanitizer }}
        CXXFLAGS: -fsanitize=${{ matrix.sanitizer }}
        LDFLAGS: -fsanitize=${{ matrix.sanitizer }}

It is also possible to set environment variables for multiple commands.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #2060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants