Add AddressSanitizer #2068
Merged
Add AddressSanitizer #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantehchang
force-pushed
the
add-address-sanitizer
branch
6 times, most recently
from
111fa42 to
766e3a7
Compare
wantehchang
commented
Mar 20, 2024
|
|
||
| env: | ||
| CC: clang | ||
| CXX: clang++ |
There was a problem hiding this comment.
If I don't delete these three lines, I get segmentation faults in the "ubuntu-latest, address" configuration:
https://github.com/AOMediaCodec/libavif/actions/runs/8351405561/job/22859682384?pr=2068
I don't know why.
There was a problem hiding this comment.
In my testing today the segmentation faults are gone. Strange.
There was a problem hiding this comment.
I rebased this pull request and the segmentation faults still did not come back. I don't know what changed that fixed the segmentation faults. I guess it will remain a mystery. :-(
wantehchang
force-pushed
the
add-address-sanitizer
branch
from
766e3a7 to
6ef2c01
Compare
wantehchang
force-pushed
the
add-address-sanitizer
branch
6 times, most recently
from
d1ec2ef to
5e47554
Compare
wantehchang
force-pushed
the
add-address-sanitizer
branch
from
5e47554 to
f3beddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.