Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further cleanup in avifParseSampleDescriptionBox() #2143

Conversation

wantehchang
Copy link
Collaborator

Rename the remainingBytes variable as sampleEntryBytes. The remainingBytes name made sense when the variable stored the return value of avifROStreamRemainingBytes(&s). The variable now stores the value of sampleEntryHeader.size, so the name sampleEntryBytes is more appropriate.

Remove an extraneous pair of parentheses around a conditional expression.

Replace an instance of sampleEntryHeader.size with sampleEntryBytes.

Rename the `remainingBytes` variable as `sampleEntryBytes`. The
`remainingBytes` name made sense when the variable stored the return
value of avifROStreamRemainingBytes(&s). The variable now stores the
value of sampleEntryHeader.size, so the name `sampleEntryBytes` is more
appropriate.

Remove an extraneous pair of parentheses around a conditional
expression.

Replace an instance of sampleEntryHeader.size with `sampleEntryBytes`.
@wantehchang wantehchang requested review from vigneshvg and y-guyon May 1, 2024 22:22
@wantehchang
Copy link
Collaborator Author

PTAL. This is a follow-up to #2140.

src/read.c Outdated Show resolved Hide resolved
@wantehchang wantehchang merged commit 7be0c35 into AOMediaCodec:main May 2, 2024
11 checks passed
@wantehchang wantehchang deleted the avifParseSampleDescriptionBox-cleanup branch May 2, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants