Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sizeof call in memset #2379

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Fix sizeof call in memset #2379

merged 2 commits into from
Aug 9, 2024

Conversation

maryla-uc
Copy link
Collaborator

No description provided.

wantehchang
wantehchang approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can look at our Coverity defects to see if it detected this bug.

src/gainmap.c Show resolved Hide resolved
@maryla-uc maryla-uc merged commit 58acc88 into AOMediaCodec:main Aug 9, 2024
14 checks passed
@wantehchang
Copy link
Collaborator

I checked our Coverity defects. It did not seem to detect this error. Strange.

@maryla-uc
Copy link
Collaborator Author

I assume the bug was not caught because the two structs happen to have the exact same size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-guyon y-guyon y-guyon approved these changes

@wantehchang wantehchang wantehchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maryla-uc @wantehchang @y-guyon