-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore gain maps with unsupported version #2380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much for working through the version checking and adding tests. It's good that you made the version check future-proof (by adding the supportedMetadataVersion
variable).
Nit: The commit message could mention the change to the check of remaining data.
733374c
to
5196d1b
Compare
@maryla-uc
|
Filed a new issue for it: #2391 |
Issue #2369