Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore gain maps with unsupported version #2380

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

maryla-uc
Copy link
Collaborator

Issue #2369

Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for working through the version checking and adding tests. It's good that you made the version check future-proof (by adding the supportedMetadataVersion variable).

Nit: The commit message could mention the change to the check of remaining data.

src/read.c Outdated Show resolved Hide resolved
src/read.c Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
include/avif/avif.h Outdated Show resolved Hide resolved
include/avif/avif.h Outdated Show resolved Hide resolved
include/avif/avif.h Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
src/read.c Outdated Show resolved Hide resolved
@maryla-uc maryla-uc merged commit d142df6 into AOMediaCodec:main Aug 9, 2024
15 checks passed
wantehchang added a commit to wantehchang/libavif that referenced this pull request Aug 9, 2024
wantehchang added a commit that referenced this pull request Aug 12, 2024
@leo-barnes
Copy link

@maryla-uc
I notice that supported_gainmap_writer_version_with_extra_bytes.avif is not actually a valid tmap file. The ispe property associated with the tmap has width and height set to 0.

      [ 8] ('ispe' "Image Spatial Extents", size = 20, offset = 493) {
        Version: 0, Flags: 0x000000
        Image Width: 0
        Image Height: 0
      }

@leo-barnes
Copy link

@maryla-uc I notice that supported_gainmap_writer_version_with_extra_bytes.avif is not actually a valid tmap file. The ispe property associated with the tmap has width and height set to 0.

      [ 8] ('ispe' "Image Spatial Extents", size = 20, offset = 493) {
        Version: 0, Flags: 0x000000
        Image Width: 0
        Image Height: 0
      }

Filed a new issue for it: #2391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants