Update AVIF_MATRIX_COEFFICIENTS_YCGCO_RE and _RO #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the values defined by H.273 (09/23).
wantehchang
approved these changes
Aug 12, 2024
wantehchang
reviewed
Aug 12, 2024
| @@ -400,8 +400,8 @@ enum | |||
| AVIF_MATRIX_COEFFICIENTS_CHROMA_DERIVED_CL = 13, | |||
| AVIF_MATRIX_COEFFICIENTS_ICTCP = 14, | |||
| #if defined(AVIF_ENABLE_EXPERIMENTAL_YCGCO_R) | |||
| AVIF_MATRIX_COEFFICIENTS_YCGCO_RE = 15, | |||
| AVIF_MATRIX_COEFFICIENTS_YCGCO_RO = 16, | |||
| AVIF_MATRIX_COEFFICIENTS_YCGCO_RE = 16, | |||
There was a problem hiding this comment.
Optional: It would be good to add a comment on what value 15 is. But I see value 3 is also missing and we don't have a comment for that. So it should be fine to not add a comment.
There was a problem hiding this comment.
Are 3 and 15 both "Reserved" in the latest edition?
There was a problem hiding this comment.
I checked H.273 (09/23). 3 is reserved, and 15 is IPT-C2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the values defined by H.273 (09/23).
See #2077.