Fix fuzzer following gain map API changes #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantehchang
approved these changes
Aug 21, 2024
wantehchang
reviewed
Aug 21, 2024
| if (tmapParsingRes == AVIF_RESULT_NOT_IMPLEMENTED) { | ||
| // Unsupported gain map version. Simply ignore the gain map. | ||
| avifGainMapDestroy(decoder->image->gainMap); | ||
| decoder->image->gainMap = NULL; |
There was a problem hiding this comment.
If we return from the AVIF_CHECKRES at line 5428, is decoder->image->gainMap guaranteed to be NULL?
There was a problem hiding this comment.
If AVIF_CHECKRES returns an error, decoder->image->gainMap might be set even if gainMapPresent is false (inconsistent state). But If the function returns an error, it doesn't have to guarantee anything about the output, does it?
There was a problem hiding this comment.
The fact that consistency is not guaranteed is not new and was already the case before this patch so I will submit for now and we can revisit in another patch if needed.
y-guyon
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a little bit of gain map reading cleanup in read.c (assume enableParsingGainMapMetadata is true in avifDecoderFindGainMapItem)