Check that the gain map metadata is valid on decoding. #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All fraction denominators must be != 0, and the gamma numerator must also be != 0. Files with invalid gain map metadata are rejected.
y-guyon
approved these changes
Oct 1, 2024
maryla-uc
added a commit
to maryla-uc/libavif
that referenced
this pull request
Oct 21, 2024
…iaCodec#2453)" I had forgotten to merge it and merged it after a couple of weeks thinking it would be fine because github was green but it broke. This reverts commit 5b6fe91.
maryla-uc
added a commit
that referenced
this pull request
Oct 21, 2024
|
Plot twist: the breakage was unrelated to this commit? |
maryla-uc
added a commit
to maryla-uc/libavif
that referenced
this pull request
Oct 24, 2024
…diaCodec#2453)" (AOMediaCodec#2482) This reverts commit aa9f740.
maryla-uc
added a commit
to maryla-uc/libavif
that referenced
this pull request
Oct 24, 2024
…diaCodec#2453)" (AOMediaCodec#2482) This reverts commit aa9f740.
maryla-uc
added a commit
to maryla-uc/libavif
that referenced
this pull request
Oct 30, 2024
…diaCodec#2453)" (AOMediaCodec#2482) This reverts commit aa9f740.
maryla-uc
added a commit
to maryla-uc/libavif
that referenced
this pull request
Oct 30, 2024
…diaCodec#2453)" (AOMediaCodec#2482) This reverts commit aa9f740.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All fraction denominators must be != 0, and the gamma numerator must also be != 0. Files with invalid gain map metadata are rejected.